[HttpKernel] [WCM] Document the MapSessionParameter value resolver #19728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
jtattevin
force-pushed
the
MapSession
branch
4 times, most recently
from
a19319e to
5f7a0d2
Compare
fabpot
reviewed
Apr 5, 2024
session.rst
Outdated
|
|
||
| namespace App\Model; | ||
|
|
||
| class PreferenceDTO |
There was a problem hiding this comment.
Not sure we need the DTO suffix here. Maybe just Preferences? or UserPreferences?
There was a problem hiding this comment.
Renamed to UserPreferences to show more that it's related to the current user and not the system
jtattevin
changed the title
javiereguiluz
added
the
Waiting Code Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See symfony/symfony#54458